Fix wait-loop in domain E2E test

[dsimansk]

Description

Changes

• Add trim to domain wait loop

There's an ongoing intermittent failure that causing flaked E2E tests. The wait loop doesn't seem to be very effective to prevent those. Trying to add simple string trim. Any other ideas are welcome. :)

/cc @rhuss

Reference

Fixes #1873

Release Note

Fix wait-loop in domain E2E test

[knative-prow]

@dsimansk: 0 warnings.

In response to this:

Description

Changes

• Add trim to domain wait loop

There's an ongoing intermittent failure that causing flaked E2E tests. The wait loop doesn't seem to be very effective to prevent those. Trying to add simple string trim. Any other ideas are welcome. :)

/cc @rhuss

Reference

Fixes #

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (03e5516) to head (ddd343c).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1919   +/-   ##
=======================================
  Coverage   74.58%   74.58%           
=======================================
  Files         207      207           
  Lines       15563    15563           
=======================================
  Hits        11607    11607           
  Misses       3167     3167           
  Partials      789      789           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dsimansk]

/test all

[dsimansk]

/test integration-tests-latest-release_client_main

[dsimansk]

/test integration-tests-latest-release_client_main
/integration-tests_client_main

[dsimansk]

It seems to be more stable, might be really a matter of sanitizing the string before in the wait loop then.

[dsimansk]

For a quick comparison the other PR run into the issue with flake immediately, #1920.

[rhuss]

Looks good to me, but do you why there could be strings with spaces only occur ? 🤔 Feel free to unhold though.

/approve
/lgtm
/hold

[dsimansk]

/test all

[dsimansk]

@rhuss with the recent run it's not really fixing anything, just a placebo. I'll try to debug it further.

[dsimansk]

@rhuss found it per 8e75391.

[dsimansk]

There's potentially another flake unrelated to domain wait loop.

https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_client/1919/integration-tests-latest-release_client_main/1768652899295956992#1:build-log.txt%3A905

[dsimansk]

/retest

[dsimansk]

/retest

[dsimansk]

/retest

[rhuss]

/approve
/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dsimansk]

/unhold