-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanding Visibility Setting #198
Comments
This should be worked on Gateway API v0.4.0 or later as Gateway API still changes the design. |
This patch removes `networking.knative.dev/visibility` validation. Curently only `cluster-local` can be specified. Fix knative#8185 Part of knative-extensions/net-gateway-api#198
This patch removes `networking.knative.dev/visibility` validation. Curently only `cluster-local` can be specified. Fix knative#8185 Part of knative-extensions/net-gateway-api#198
This patch removes `networking.knative.dev/visibility` validation. Curently only `cluster-local` can be specified. Fix knative#8185 Part of knative-extensions/net-gateway-api#198
This patch removes `networking.knative.dev/visibility` validation. Curently only `cluster-local` can be specified. Fix #8185 Part of knative-extensions/net-gateway-api#198
This issue is stale because it has been open for 90 days with no |
Following up here we may want to add similar functionality that just landed in the net-istio about a greater control of gateway selection Details in the feature track https://docs.google.com/document/d/12X1-9nhjAhpf-Wlt3RbdoMbvx31zFBva/edit?pli=1#heading=h.gjdgxs |
The background is described in original issue - knative/serving#6642
The original design introduced
Realm
andDomain
CRDs but it stopped developing as the design is difficult to align with Ingress v2 (Gateway API).The new Gateway API controller has visibility based setting (it maps one Visibility to one Gateway) like:
https://github.com/knative-sandbox/net-gateway-api/blob/9218e0d7ff957b2ea4ec106abfdd018988bf72a3/config/config-gateway.yaml#L42-L50
So it will be possible to achieve the goal what knative/serving#6642 tried to address.
The text was updated successfully, but these errors were encountered: