Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestResolveAddress should allow overriding test image #304

Closed
mgencur opened this issue Aug 9, 2023 · 4 comments
Closed

TestResolveAddress should allow overriding test image #304

mgencur opened this issue Aug 9, 2023 · 4 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@mgencur
Copy link

mgencur commented Aug 9, 2023

The test is located here and it consumes test cases defined in pkg/k8s/test/addressresolver_cases.go.
The test case hardcodes the gcr.io/knative-samples/helloworld-go image which is not multiarch.
We would like to be able to define TEST_IMAGES_HELLOWORLD_GO env variable to override the image. The image resolver should be able to replace the hardcoded one with the one define via env variable. This way we could pass a multiarch version of that image, for example.

Similar approach is used for other E2E tests, for example the wathola-forwarder image can be overridden via env variable TEST_IMAGES_WATHOLA_FORWARDER: link

The TestResolveAddress test is the only E2E test which doesn't allow overriding the test image.

@cardil
Copy link
Contributor

cardil commented Oct 16, 2023

@mgencur The gcr.io/knative-samples/helloworld-go is provided from the Serving sources, right? We should open up an issue there to make it multi-arch.

@cardil
Copy link
Contributor

cardil commented Oct 16, 2023

@mgencur The gcr.io/knative-samples/helloworld-go is provided from the Serving sources, right? We should open up an issue there to make it multi-arch.

Scratch that. Those images are provided from docs repo. Some time ago, there were updated to use multi-arch: knative/docs#5273

Unfortunately, only arm64,amd64 is configured:

https://github.com/knative/docs/blob/c522018a2474384778c970b3487778207105fe3e/.github/workflows/knative-docs-image.yaml#L40-L46

Worth adding that we should use ghcr.io/knative/helloworld-go instead of gcr.io/knative-samples/helloworld-go

@cardil
Copy link
Contributor

cardil commented Oct 16, 2023

See: knative/docs#5718

Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2024
cardil pushed a commit to cardil/kn-plugin-event that referenced this issue Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants