Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use knative.dev in module name #32

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

matejvasek
Copy link
Contributor

Changes

  • 🧹 Rename the module to knative.dev/func-go.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow knative-prow bot requested review from lance and zroubalik August 3, 2023 18:35
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@matejvasek matejvasek requested review from upodroid and removed request for lance and zroubalik August 3, 2023 18:35
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2023
@matejvasek matejvasek requested a review from krsna-m August 3, 2023 18:35
@matejvasek
Copy link
Contributor Author

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@lance
Copy link
Contributor

lance commented Aug 3, 2023

/lgtm
But agree with the hold until verification

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@upodroid
Copy link

upodroid commented Aug 3, 2023

We need to merge knative/docs#5656 this first

@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@knative-prow knative-prow bot merged commit 4a1c56a into knative-extensions:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants