Provision contract fields for authorization #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
do-not-merge/work-in-progress
knative-prow
bot
added
the
size/L
knative-prow
bot
added
the
approved
creydr
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4064 +/- ##
==========================================
+ Coverage 48.23% 48.48% +0.24%
==========================================
Files 244 244
Lines 14641 14712 +71
==========================================
+ Hits 7062 7133 +71
+ Misses 6868 6867 -1
- Partials 711 712 +1 ☔ View full report in Codecov by Sentry. |
creydr
force-pushed
the
provision-contract-fields-for-authz-simple
branch
2 times, most recently
from
16412ea to
7fdc00c
Compare
creydr
force-pushed
the
provision-contract-fields-for-authz-simple
branch
from
7fdc00c to
bcb5ead
Compare
knative-prow
bot
added
size/XL
creydr
force-pushed
the
provision-contract-fields-for-authz-simple
branch
from
bcb5ead to
c7c740a
Compare
creydr
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
creydr
changed the title
pierDipi
reviewed
Aug 20, 2024
creydr
force-pushed
the
provision-contract-fields-for-authz-simple
branch
from
d05188d to
51759b5
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4041
Proposed Changes
Hint: currently only the Broker exposes the applying policies in its status. KafkaChannel and KafkaSink are open/WIP #4038 and #4039)