Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set consumer and consumergroups finalizers when creating them #3355

Merged
merged 2 commits into from
Sep 27, 2023

Fix unit tests

5e5e8a6
Select commit
Loading
Failed to load commit list.
Merged

Set consumer and consumergroups finalizers when creating them #3355

Fix unit tests
5e5e8a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 27, 2023 in 0s

58.53% (-3.09%) compared to e7f53ae

View this Pull Request on Codecov

58.53% (-3.09%) compared to e7f53ae

Details

Codecov Report

Merging #3355 (5e5e8a6) into main (e7f53ae) will decrease coverage by 3.09%.
Report is 8 commits behind head on main.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main    #3355      +/-   ##
============================================
- Coverage     61.61%   58.53%   -3.09%     
============================================
  Files           182       91      -91     
  Lines         12331     9237    -3094     
  Branches        268        0     -268     
============================================
- Hits           7598     5407    -2191     
+ Misses         4136     3402     -734     
+ Partials        597      428     -169     
Files Coverage Δ
control-plane/pkg/reconciler/source/source.go 88.38% <100.00%> (+0.22%) ⬆️
...ls/kafka/eventing/v1alpha1/consumer_group_types.go 26.78% <0.00%> (-0.49%) ⬇️

... and 92 files with indirect coverage changes