Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data-plane]: Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.1.0 to 3.4.1 in /data-plane #3329

Closed
wants to merge 2 commits into from
Closed

[data-plane]: Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.1.0 to 3.4.1 in /data-plane #3329

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 11, 2023 •
edited
Loading

Bumps org.apache.maven.plugins:maven-enforcer-plugin from 3.1.0 to 3.4.1.

Release notes

Sourced from org.apache.maven.plugins:maven-enforcer-plugin's releases.

3.4.1

🐛 Bug Fixes

👻 Maintenance

3.4.0

🚀 New features and improvements

🐛 Bug Fixes

📦 Dependency updates

📝 Documentation updates

  • Clarify availability of AbstractEnforcerRule (#278) @​kwin

👻 Maintenance

  • Bump org.junit:junit-bom from 5.9.3 to 5.10.0 (#280) @​dependabot
  • Bump snappy-java from 1.1.8.3 to 1.1.10.1 in /maven-enforcer-plugin/src/it/projects/dependency-convergence_transitive_provided/module1 (#273) @​dependabot
  • [MNG-6829] - Replace StringUtils#isEmpty(String) and #isNotEmpty(String) (#272) @​timtebeek

3.3.0

... (truncated)

Commits
  • d8a21ee [maven-release-plugin] prepare release enforcer-3.4.1
  • 66250c0 [MENFORCER-491] Fix plugin documentation generation
  • 5d32e6c [MENFORCER-490] Declare maven-enforcer-plugin dependencies (#285)
  • d258109 [MENFORCER-490] Declare org.eclipse.sisu.plexus dependencies (#283)
  • 2aa71e7 [MENFORCER-490] Declare maven-enforcer-extension dependencies (#284)
  • d4ec8e1 [MENFORCER-490] Declare maven-enforcer-extension dependencies (#282)
  • b35e4a0 [maven-release-plugin] prepare for next development iteration
  • 3d365f7 [maven-release-plugin] prepare release enforcer-3.4.0
  • 5feb93a [MENFORCER-489] Bump commons-lang3 from 3.12.0 to 3.13.0
  • 8f2de47 Bump org.junit:junit-bom from 5.9.3 to 5.10.0
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 11, 2023
@dependabot dependabot bot mentioned this pull request Sep 11, 2023
Closed
@knative-prow
Copy link

knative-prow bot commented Sep 11, 2023

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2023
@knative-prow knative-prow bot requested a review from aliok September 11, 2023 20:35
@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #3329 (a1cf00d) into main (9ef55f2) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head a1cf00d differs from pull request most recent head f5c4f91. Consider uploading reports for the commit f5c4f91 to get more accurate results

@@             Coverage Diff              @@
##               main    #3329      +/-   ##
============================================
- Coverage     61.55%   61.53%   -0.03%     
+ Complexity      762      761       -1     
============================================
  Files           181      181              
  Lines         12400    12400              
  Branches        265      265              
============================================
- Hits           7633     7630       -3     
- Misses         4165     4167       +2     
- Partials        602      603       +1
Flag Coverage Δ
java-unittests 70.84% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@creydr
Copy link
Contributor

creydr commented Oct 23, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 23, 2023
@creydr
Copy link
Contributor

creydr commented Oct 23, 2023

@dependabot rebase

@dependabot
[data-plane]: Bump org.apache.maven.plugins:maven-enforcer-plugin
a1cf00d 
Bumps [org.apache.maven.plugins:maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.1.0 to 3.4.1.
- [Release notes](https://github.com/apache/maven-enforcer/releases)
- [Commits](apache/maven-enforcer@enforcer-3.1.0...enforcer-3.4.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-enforcer-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/data-plane/main/org.apache.maven.plugins-maven-enforcer-plugin-3.4.1 branch from 520560b to a1cf00d Compare October 23, 2023 15:56
@knative-prow
Copy link

knative-prow bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from pierdipi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-automation
[dependabot skip] Update data-plane/THIRD-PARTY.txt
f5c4f91 
Signed-off-by: Knative Automation <automation@knative.team>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 23, 2023

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-tests_eventing-kafka-broker_main f5c4f91 link true /test integration-tests
channel-integration-tests-sasl-plain_eventing-kafka-broker_main f5c4f91 link true /test channel-integration-tests-sasl-plain
channel-integration-tests-sasl-ssl_eventing-kafka-broker_main f5c4f91 link true /test channel-integration-tests-sasl-ssl
reconciler-tests_eventing-kafka-broker_main f5c4f91 link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@creydr
Copy link
Contributor

creydr commented Oct 24, 2023

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 24, 2023

Looks like org.apache.maven.plugins:maven-enforcer-plugin is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Oct 24, 2023
@dependabot dependabot bot deleted the dependabot/maven/data-plane/main/org.apache.maven.plugins-maven-enforcer-plugin-3.4.1 branch October 24, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@matzew matzew Awaiting requested review from matzew

@aliok aliok Awaiting requested review from aliok

Assignees

@pierDipi pierDipi

Labels
area/data-plane dependencies Pull requests that update a dependency file java Pull requests that update Java code ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@creydr @pierDipi @knative-automation