Upgrade to latest dependencies #3321

creydr · 2023-09-07T10:02:38Z

#3318 has some build issues. This PR addresses it

codecov · 2023-09-07T10:09:06Z

Codecov Report

Merging #3321 (5562021) into main (d4caf75) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 51.72%.

@@             Coverage Diff              @@
##               main    #3321      +/-   ##
============================================
- Coverage     61.61%   61.58%   -0.04%     
+ Complexity      770      769       -1     
============================================
  Files           182      182              
  Lines         12337    12337              
  Branches        268      268              
============================================
- Hits           7602     7598       -4     
- Misses         4139     4142       +3     
- Partials        596      597       +1

Flag	Coverage Δ
java-unittests	`71.06% <ø> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...pkg/apis/eventing/v1alpha1/kafka_sink_lifecycle.go	`73.33% <100.00%> (-1.67%)`	⬇️
...l-plane/pkg/reconciler/consumergroup/controller.go	`55.43% <100.00%> (-0.25%)`	⬇️
...lane/pkg/reconciler/base/receiver_condition_set.go	`0.00% <0.00%> (ø)`

... and 2 files with indirect coverage changes

creydr · 2023-09-07T13:24:38Z

Has some other issues too:

Error from server (BadRequest): container "kafka-source-dispatcher" in pod "kafka-source-dispatcher-0" is waiting to start: ContainerCreating

we see the following event assigned to the pod:

kind: Event
  ...
  note: 'MountVolume.SetUp failed for volume "contract-resources" : configmap "kafka-source-dispatcher-0"
    not found'
  reason: FailedMount
  regarding:
    apiVersion: v1
    kind: Pod
    name: kafka-source-dispatcher-0
    namespace: knative-eventing
  type: Warning

But no configmap with this name:

>>> configmaps (63 objects)
>>> Listing
NAMESPACE          NAME                                                   DATA   AGE
...
knative-eventing   config-br-default-channel                              1      13m
knative-eventing   config-br-defaults                                     1      13m
knative-eventing   config-features                                        7      13m
knative-eventing   config-kafka-autoscaler                                7      5m31s
knative-eventing   config-kafka-broker-data-plane                         5      5m27s
knative-eventing   config-kafka-channel-data-plane                        5      5m24s
knative-eventing   config-kafka-descheduler                               2      5m31s
knative-eventing   config-kafka-features                                  6      5m31s
knative-eventing   config-kafka-leader-election                           6      5m31s
knative-eventing   config-kafka-scheduler                                 2      5m31s
knative-eventing   config-kafka-sink-data-plane                           3      5m26s
knative-eventing   config-kafka-source-data-plane                         4      5m28s
knative-eventing   config-kafka-source-defaults                           1      5m31s
knative-eventing   config-kreference-mapping                              1      13m
knative-eventing   config-leader-election                                 1      13m
knative-eventing   config-logging                                         3      13m
knative-eventing   config-namespaced-broker-resources                     1      5m31s
knative-eventing   config-observability                                   1      13m
knative-eventing   config-ping-defaults                                   1      13m
knative-eventing   config-sugar                                           1      13m
knative-eventing   config-tracing                                         4      13m
knative-eventing   default-ch-webhook                                     1      13m
knative-eventing   kafka-broker-brokers-triggers                          1      5m28s
knative-eventing   kafka-broker-config                                    3      5m32s
knative-eventing   kafka-channel-channels-subscriptions                   1      5m27s
knative-eventing   kafka-channel-config                                   1      5m31s
knative-eventing   kafka-config-logging                                   1      5m31s
knative-eventing   kafka-sink-sinks                                       1      5m27s
knative-eventing   kube-root-ca.crt                                       1      13m
kube-node-lease    kube-root-ca.crt                                       1      15m
...

pierDipi · 2023-09-07T14:47:34Z

/test ?

knative-prow · 2023-09-07T14:47:36Z

@pierDipi: The following commands are available to trigger required jobs:

/test build-tests
/test channel-integration-tests-sasl-plain
/test channel-integration-tests-sasl-ssl
/test channel-integration-tests-ssl
/test channel-reconciler-tests-sasl-plain
/test channel-reconciler-tests-sasl-ssl
/test channel-reconciler-tests-ssl
/test integration-tests
/test reconciler-tests
/test reconciler-tests-namespaced-broker
/test unit-tests
/test upgrade-tests

The following commands are available to trigger optional jobs:

/test reconciler-tests-loom
/test reconciler-tests-namespaced-broker-loom

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

creydr · 2023-09-11T15:50:10Z

Seems this comes, because the kafka-source-dispatcher-0 does not get scaled back to 0 again. Could be related to knative/eventing#7027 🤔
Before I dig deeper into it: @pierDipi does this ring any bells on you?

pierDipi · 2023-09-11T15:52:47Z

Yes @creydr, I'm testing a patch for the autoscaler/scheduler, it takes some time since it's using our days long running tests

creydr · 2023-09-11T15:58:37Z

Yes @creydr, I'm testing a patch for the autoscaler/scheduler, it takes some time since it's using our days long running tests

Ah ok. Thanks 👍

creydr · 2023-09-22T15:48:06Z

Latest changes did not fix it. Still having the kafka-source-dispatcher-0 not getting scaled back to 0 again. In addition I see these events:

3m28s       Warning   FailedGetResourceMetric        horizontalpodautoscaler/eventing-webhook                    failed to get cpu utilization: unable to get metrics for resource cpu: unable to fetch metrics from resource metrics API: the server could not find the requested resource (get pods.metrics.k8s.io)
45m         Warning   FailedComputeMetricsReplicas   horizontalpodautoscaler/eventing-webhook                    invalid metrics (1 invalid out of 1), first error is: failed to get cpu resource metric value: failed to get cpu utilization: unable to get metrics for resource cpu: unable to fetch metrics from resource metrics API: the server could not find the requested resource (get pods.metrics.k8s.io)

pierDipi · 2023-09-27T10:30:57Z

I rebased the PR for another test run on top of the latest changes

pierDipi · 2023-09-27T10:32:15Z

/test ?

knative-prow · 2023-09-27T10:32:17Z

@pierDipi: The following commands are available to trigger required jobs:

/test build-tests
/test channel-integration-tests-sasl-plain
/test channel-integration-tests-sasl-ssl
/test channel-integration-tests-ssl
/test channel-reconciler-tests-sasl-plain
/test channel-reconciler-tests-sasl-ssl
/test channel-reconciler-tests-ssl
/test integration-tests
/test reconciler-tests
/test reconciler-tests-namespaced-broker
/test unit-tests
/test upgrade-tests

The following commands are available to trigger optional jobs:

/test reconciler-tests-keda
/test reconciler-tests-loom
/test reconciler-tests-namespaced-broker-loom

Use /test all to run the following jobs that were automatically triggered:

build-tests_eventing-kafka-broker_main
channel-integration-tests-sasl-plain_eventing-kafka-broker_main
channel-integration-tests-sasl-ssl_eventing-kafka-broker_main
channel-integration-tests-ssl_eventing-kafka-broker_main
channel-reconciler-tests-sasl-plain_eventing-kafka-broker_main
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main
channel-reconciler-tests-ssl_eventing-kafka-broker_main
integration-tests_eventing-kafka-broker_main
reconciler-tests-namespaced-broker_eventing-kafka-broker_main
reconciler-tests_eventing-kafka-broker_main
unit-tests_eventing-kafka-broker_main
upgrade-tests_eventing-kafka-broker_main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Cali0707 · 2023-09-28T19:22:33Z

/test all

creydr · 2023-09-29T05:55:01Z

/retest

knative-prow · 2023-09-29T06:56:57Z

@creydr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
reconciler-tests-namespaced-broker-loom_eventing-kafka-broker_main	`9bcebcb`	link	false	`/test reconciler-tests-namespaced-broker-loom`
reconciler-tests-loom_eventing-kafka-broker_main	`9bcebcb`	link	false	`/test reconciler-tests-loom`
reconciler-tests-keda_eventing-kafka-broker_main	`9bcebcb`	link	false	`/test reconciler-tests-keda`

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

creydr · 2023-09-29T06:58:43Z

/retest-required

creydr · 2023-09-29T08:28:27Z

@Cali0707 @matzew It finally passed 🎉
Could you review?

/cc @pierDipi

pierDipi

/lgtm
/approve

knative-prow · 2023-09-29T08:38:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [creydr,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow bot added the area/control-plane label Sep 7, 2023

knative-prow bot requested review from aliok and lionelvillard September 7, 2023 10:02

knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2023

knative-prow bot added the area/test label Sep 11, 2023

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2023

knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2023

creydr force-pushed the update-dependencies-230907 branch from 4c2776e to 9bcebcb Compare September 22, 2023 13:20

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2023

Cali0707 mentioned this pull request Sep 26, 2023

[WIP]: Move new trigger filters tests to e2e_new #3363

Closed

pierDipi force-pushed the update-dependencies-230907 branch from 9bcebcb to c93e9ed Compare September 27, 2023 10:30

creydr added 3 commits September 28, 2023 07:49

Update dependencies

d59d88b

Fix build issue (switch to statefulsetscheduler.New())

1e0c1ca

Fix more build issues (broker.SetAddress())

aacc4a6

creydr force-pushed the update-dependencies-230907 branch from c93e9ed to aacc4a6 Compare September 28, 2023 05:51

Use MAXFILLUP

5562021

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

knative-prow bot requested a review from pierDipi September 29, 2023 08:28

pierDipi approved these changes Sep 29, 2023

View reviewed changes

knative-prow bot assigned pierDipi Sep 29, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2023

knative-prow bot merged commit 977b7ed into knative-extensions:main Sep 29, 2023
19 of 22 checks passed

creydr mentioned this pull request Oct 2, 2023

[main] Upgrade to latest dependencies #3318

Closed

creydr mentioned this pull request Oct 26, 2023

[flaky] test/e2e_new.TestKafkaSource* #3438

Closed

Cali0707 mentioned this pull request Oct 26, 2023

[release-1.11] Upgrade to latest dependencies #3393

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to latest dependencies #3321

Upgrade to latest dependencies #3321

creydr commented Sep 7, 2023

codecov bot commented Sep 7, 2023 •

edited

Loading

creydr commented Sep 7, 2023

pierDipi commented Sep 7, 2023

knative-prow bot commented Sep 7, 2023

creydr commented Sep 11, 2023

pierDipi commented Sep 11, 2023

creydr commented Sep 11, 2023

creydr commented Sep 22, 2023

pierDipi commented Sep 27, 2023

pierDipi commented Sep 27, 2023

knative-prow bot commented Sep 27, 2023

Cali0707 commented Sep 28, 2023

creydr commented Sep 29, 2023

knative-prow bot commented Sep 29, 2023 •

edited

Loading

creydr commented Sep 29, 2023

creydr commented Sep 29, 2023

pierDipi left a comment

knative-prow bot commented Sep 29, 2023

Upgrade to latest dependencies #3321

Upgrade to latest dependencies #3321

Conversation

creydr commented Sep 7, 2023

codecov bot commented Sep 7, 2023 • edited Loading

Codecov Report

creydr commented Sep 7, 2023

pierDipi commented Sep 7, 2023

knative-prow bot commented Sep 7, 2023

creydr commented Sep 11, 2023

pierDipi commented Sep 11, 2023

creydr commented Sep 11, 2023

creydr commented Sep 22, 2023

pierDipi commented Sep 27, 2023

pierDipi commented Sep 27, 2023

knative-prow bot commented Sep 27, 2023

Cali0707 commented Sep 28, 2023

creydr commented Sep 29, 2023

knative-prow bot commented Sep 29, 2023 • edited Loading

creydr commented Sep 29, 2023

creydr commented Sep 29, 2023

pierDipi left a comment

Choose a reason for hiding this comment

knative-prow bot commented Sep 29, 2023

codecov bot commented Sep 7, 2023 •

edited

Loading

knative-prow bot commented Sep 29, 2023 •

edited

Loading