Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose init offset and schedule metrics for ConsumerGroup reconciler #3294

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Aug 21, 2023

These 2 metrics will allow monitoring the reconciler main actions that are sometimes slow.

Proposed Changes

  • Expose init offset and schedule metrics for ConsumerGroup reconciler

Release Note


Docs

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2023
@knative-prow knative-prow bot added area/control-plane size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 21, 2023
@pierDipi pierDipi force-pushed the expose-init-offset-and-schedule-metrics branch from bdab820 to 9b596bb Compare August 21, 2023 11:34
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #3294 (da76e75) into main (c402ae9) will increase coverage by 0.08%.
Report is 2 commits behind head on main.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##               main    #3294      +/-   ##
============================================
+ Coverage     61.78%   61.87%   +0.08%     
- Complexity      764      766       +2     
============================================
  Files           181      181              
  Lines         12220    12266      +46     
  Branches        266      266              
============================================
+ Hits           7550     7589      +39     
- Misses         4081     4085       +4     
- Partials        589      592       +3     
Flag Coverage Δ
java-unittests 71.74% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../pkg/reconciler/consumergroup/autoscaler_config.go 0.00% <0.00%> (ø)
...lane/pkg/reconciler/consumergroup/consumergroup.go 55.20% <82.75%> (+2.46%) ⬆️
control-plane/pkg/reconciler/consumergroup/auth.go 74.13% <100.00%> (ø)
...trol-plane/pkg/reconciler/consumergroup/evictor.go 76.92% <100.00%> (-7.08%) ⬇️

... and 2 files with indirect coverage changes

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the expose-init-offset-and-schedule-metrics branch from 9b596bb to da76e75 Compare August 21, 2023 12:42
@pierDipi pierDipi changed the title [WIP] Expose init offset and schedule metrics for ConsumerGroup reconciler Expose init offset and schedule metrics for ConsumerGroup reconciler Aug 22, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2023
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 0242a87 into knative-extensions:main Aug 22, 2023
20 of 22 checks passed
@pierDipi
Copy link
Member Author

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@pierDipi: #3294 failed to apply on top of branch "release-1.11":

Applying: Expose init offset and schedule metrics for ConsumerGroup reconciler
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/consumergroup/consumergroup.go
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging control-plane/pkg/reconciler/consumergroup/consumergroup.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Expose init offset and schedule metrics for ConsumerGroup reconciler
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants