-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose init offset and schedule metrics for ConsumerGroup reconciler #3294
Expose init offset and schedule metrics for ConsumerGroup reconciler #3294
Conversation
bdab820
to
9b596bb
Compare
Codecov Report
@@ Coverage Diff @@
## main #3294 +/- ##
============================================
+ Coverage 61.78% 61.87% +0.08%
- Complexity 764 766 +2
============================================
Files 181 181
Lines 12220 12266 +46
Branches 266 266
============================================
+ Hits 7550 7589 +39
- Misses 4081 4085 +4
- Partials 589 592 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
9b596bb
to
da76e75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0242a87
into
knative-extensions:main
/cherry-pick release-1.11 |
@pierDipi: #3294 failed to apply on top of branch "release-1.11":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
These 2 metrics will allow monitoring the reconciler main actions that are sometimes slow.
Proposed Changes
Release Note
Docs