Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace knative-sandbox with knative-extensions #3258

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Replace knative-sandbox with knative-extensions #3258

merged 1 commit into from
Aug 15, 2023

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Aug 1, 2023

Testing EasyCLA by cleaning up references to old org.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/control-plane labels Aug 1, 2023
Cali0707
Cali0707 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@Cali0707
Copy link
Member

Cali0707 commented Aug 2, 2023

/cc @creydr

@knative-prow knative-prow bot requested a review from creydr August 2, 2023 17:42
@Cali0707
Copy link
Member

Cali0707 commented Aug 2, 2023

/retest-required

creydr
creydr approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@pierDipi
Copy link
Member

pierDipi commented Aug 3, 2023

/retest

3 similar comments
@matzew
Copy link
Contributor

matzew commented Aug 3, 2023

/retest

@upodroid
Copy link
Contributor Author

/retest

@matzew
Copy link
Contributor

matzew commented Aug 15, 2023

/retest

@knative-prow knative-prow bot merged commit 12e8610 into main Aug 15, 2023
24 of 26 checks passed
@upodroid upodroid deleted the update-sandbox-references branch August 15, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@creydr creydr creydr approved these changes

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@creydr creydr

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@upodroid @Cali0707 @pierDipi @matzew @creydr