Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Don't use hardcoded namespace #3253

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #3251

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/control-plane labels Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #3253 (103f95a) into release-1.11 (d65fe32) will not change coverage.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##             release-1.11    #3253   +/-   ##
===============================================
  Coverage           63.58%   63.58%           
  Complexity            774      774           
===============================================
  Files                 170      170           
  Lines               11957    11957           
  Branches              250      250           
===============================================
  Hits                 7603     7603           
  Misses               3777     3777           
  Partials              577      577           
Flag Coverage Δ
java-unittests 80.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
control-plane/pkg/reconciler/broker/broker.go 72.50% <100.00%> (+0.57%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi July 31, 2023 20:42
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/retest

@knative-prow
Copy link

knative-prow bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@pierDipi
Copy link
Member

pierDipi commented Aug 1, 2023

/test channel-integration-tests-sasl-plain

@knative-prow knative-prow bot merged commit 3ce91ef into knative-extensions:release-1.11 Aug 1, 2023
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants