Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestReconcileKind/Consumers_in_multiple_pods,_with_pods_pending_and_unknown_phase #3250

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

pierDipi
Copy link
Member

Fixes #3246

Proposed Changes

  • Sort pods by name to have a consistent order for creating CMs

…ding_and_unknown_phase

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane labels Jul 31, 2023
@pierDipi
Copy link
Member Author

/cc @Cali0707

@knative-prow knative-prow bot requested a review from Cali0707 July 31, 2023 09:08
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #3250 (2a1657a) into main (8a0ffa2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #3250   +/-   ##
=========================================
  Coverage     63.56%   63.56%           
  Complexity      774      774           
=========================================
  Files           170      170           
  Lines         11957    11958    +1     
  Branches        250      250           
=========================================
+ Hits           7600     7601    +1     
  Misses         3779     3779           
  Partials        578      578           
Flag Coverage Δ
java-unittests 80.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...lane/pkg/reconciler/consumergroup/consumergroup.go 52.73% <100.00%> (+0.10%) ⬆️

@pierDipi
Copy link
Member Author

/test channel-integration-tests-sasl-ssl

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krsna-m
Copy link

krsna-m commented Jul 31, 2023

/easycla

@knative-prow knative-prow bot merged commit 0a737de into knative-extensions:main Jul 31, 2023
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flaky]: consumer_group.TestReconcileKind/Consumers_in_multiple_pods,_with_pods_pending_and_unknown_phase
3 participants