Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Upgrade to latest dependencies #3244

Merged
merged 1 commit into from
Aug 2, 2023
Merged

[main] Upgrade to latest dependencies #3244

merged 1 commit into from
Aug 2, 2023

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Jul 28, 2023 •
edited
Loading

Cron -knative-prow-robot

/cc knative-extensions/eventing-writers
/assign knative-extensions/eventing-writers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-prow
Copy link

knative-prow bot commented Jul 28, 2023

@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative-sandbox/eventing-writers.

Note that only knative-sandbox members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Cron -knative-prow-robot

/cc knative-sandbox/eventing-writers
/assign knative-sandbox/eventing-writers

Produced by: knative-sandbox/knobots/actions/update-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #3244 (5b949c2) into main (acb04ea) will increase coverage by 16.69%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #3244       +/-   ##
=============================================
+ Coverage     63.63%   80.32%   +16.69%     
  Complexity      775      775               
=============================================
  Files           170       79       -91     
  Lines         11958     2800     -9158     
  Branches        250      250               
=============================================
- Hits           7609     2249     -5360     
+ Misses         3773      396     -3377     
+ Partials        576      155      -421
Flag Coverage Δ
java-unittests 80.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 91 files with indirect coverage changes

@pierDipi
Copy link
Member

@creydr is this reverting your change?

@pierDipi
Copy link
Member

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@creydr
Copy link
Contributor

creydr commented Jul 28, 2023

@creydr is this reverting your change?

seems so 🤔

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2023
@creydr
Copy link
Contributor

creydr commented Jul 31, 2023

/retest

1 similar comment
@creydr
Copy link
Contributor

creydr commented Jul 31, 2023

/retest

@knative-automation knative-automation force-pushed the auto-updates/update-deps-main branch 2 times, most recently from 5bd3441 to 5b949c2 Compare August 1, 2023 13:39
@knative-automation
upgrade to latest dependencies
2ea7af8 
bumping knative.dev/reconciler-test 26cee79...1923290:
  > 1923290 Support HTTPS in StartSenderToResource (# 560)
  > 5741fb8 Allow passing namespace for MatchPeerCertificatesFromSecret (# 558)

Signed-off-by: Knative Automation <automation@knative.team>
creydr
creydr approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/lgtm

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@creydr
Copy link
Contributor

creydr commented Aug 2, 2023

/retest

@creydr
Copy link
Contributor

creydr commented Aug 2, 2023

/test channel-integration-tests-sasl-ssl

@knative-prow knative-prow bot merged commit 5de96d5 into knative-extensions:main Aug 2, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knative-automation @pierDipi @creydr