Added empty FinalizeKind definition to prevent delete sources from hanging

[Cali0707]

Fixes #3070

Proposed Changes

• Add empty definition for FinalizeKind to ensure that deleting a source does not hang if it has a finalizer

Release Note

Fixed bug where deleting sources created before the sourcev2 upgrade caused the source to hang on finalization.

[Cali0707]

/cc @pierDipi

[codecov]

Codecov Report

Merging #3113 (c6e2a4f) into main (39fd4b3) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #3113      +/-   ##
============================================
- Coverage     63.42%   63.41%   -0.02%     
  Complexity      758      758              
============================================
  Files           167      167              
  Lines         11354    11356       +2     
  Branches        233      233              
============================================
  Hits           7201     7201              
- Misses         3626     3628       +2     
  Partials        527      527              

Flag	Coverage Δ
java-unittests	81.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
control-plane/pkg/reconciler/source/source.go	88.15% <0.00%> (-1.18%)	⬇️

... and 1 file with indirect coverage changes

[pierDipi]

To resolve the unit tests issue take a look at how we were setting up the test with WantPatches and WantEvents on the branch 1.5:

• https://github.com/knative-sandbox/eventing-kafka-broker/blob/94a5ad58082d5a590b296b440f793cb972f40468/control-plane/pkg/reconciler/source/source_test.go#L136-L141
• https://github.com/knative-sandbox/eventing-kafka-broker/blob/94a5ad58082d5a590b296b440f793cb972f40468/control-plane/pkg/reconciler/source/source_test.go#L614-L621
• https://github.com/knative-sandbox/eventing-kafka-broker/blob/94a5ad58082d5a590b296b440f793cb972f40468/control-plane/pkg/reconciler/source/source_test.go#L66-L72

[Cali0707]

To resolve the unit tests issue take a look at how we were setting up the test with WantPatches and WantEvents on the branch 1.5:

* https://github.com/knative-sandbox/eventing-kafka-broker/blob/94a5ad58082d5a590b296b440f793cb972f40468/control-plane/pkg/reconciler/source/source_test.go#L136-L141

* https://github.com/knative-sandbox/eventing-kafka-broker/blob/94a5ad58082d5a590b296b440f793cb972f40468/control-plane/pkg/reconciler/source/source_test.go#L614-L621

* https://github.com/knative-sandbox/eventing-kafka-broker/blob/94a5ad58082d5a590b296b440f793cb972f40468/control-plane/pkg/reconciler/source/source_test.go#L66-L72

Just checked those out and try to follow it, thanks for your help!!

[Cali0707]

/retest

[pierDipi]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pierDipi]

/cherry-pick release-1.10

[pierDipi]

/cherry-pick release-1.9

[knative-prow-robot]

@pierDipi: #3113 failed to apply on top of branch "release-1.10":

Applying: Added empty FinalizeKind definition to prevent delete sources from hanging
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/source/source.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane/pkg/reconciler/source/source.go
Applying: Updated tests to handle reintroduction of finalizer patch events
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/source/source_test.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane/pkg/reconciler/source/source_test.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/source/source_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Updated tests to handle reintroduction of finalizer patch events
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

@pierDipi: #3113 failed to apply on top of branch "release-1.9":

Applying: Added empty FinalizeKind definition to prevent delete sources from hanging
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/source/source.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane/pkg/reconciler/source/source.go
Applying: Updated tests to handle reintroduction of finalizer patch events
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/source/source_test.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane/pkg/reconciler/source/source_test.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/source/source_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Updated tests to handle reintroduction of finalizer patch events
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.