[WIP] Install KEDA for testing

[pierDipi]

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

Fixes #

Proposed Changes

Release Note

Docs

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #2796 (408a112) into main (d2c8547) will decrease coverage by 0.04%.
Report is 265 commits behind head on main.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##               main    #2796      +/-   ##
============================================
- Coverage     61.75%   61.71%   -0.04%     
+ Complexity      749      748       -1     
============================================
  Files           152      152              
  Lines         10712    10720       +8     
  Branches        231      231              
============================================
+ Hits           6615     6616       +1     
- Misses         3634     3639       +5     
- Partials        463      465       +2     

Flag	Coverage Δ
java-unittests	81.17% <ø> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...lane/pkg/reconciler/consumergroup/consumergroup.go	51.09% <25.00%> (-0.76%)	⬇️
...l-plane/pkg/reconciler/consumergroup/controller.go	60.75% <100.00%> (+0.50%)	⬆️

... and 1 file with indirect coverage changes

[pierDipi]

/retest-required

[pierDipi]

@aavarghese with the default values with KEDA we're slower (higher e2e latency) in our Sacura test: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2796/reconciler-tests_eventing-kafka-broker_main/1594762319668187136

[aavarghese]

/test channel-integration-tests-sasl-plain

[aavarghese]

@pierDipi Do you see higher latency errors in the failing tests?
I found a few other errors in there:

              {
                "lastTransitionTime": "2022-11-22T16:30:29Z",
                "message": "failed to set up autoscaler: SASL type value \"\" is not supported",
                "reason": "AutoscalerFailed",
                "status": "False",
                "type": "ConsumerGroup"
              },

and

{
            "type": "ConsumerGroup",
            "status": "False",
            "lastTransitionTime": "2022-11-22T16:08:15Z",
            "reason": "AutoscalerFailed",
            "message": "failed to set up autoscaler: failed to update scaled object eventing-e2e19/so-475d6208-d85e-474c-a377-85e1e57206ce: scaledobjects.keda.sh \"so-475d6208-d85e-474c-a377-85e1e57206ce\" is invalid: metadata.resourceVersion: Invalid value: 0x0: must be specified for an update"
           },

[pierDipi]

@pierDipi Do you see higher latency errors in the failing tests? I found a few other errors in there:

Yes, https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/2796/reconciler-tests_eventing-kafka-broker_main/1595347805788966912

However, I think we should allow configuring default values for the autoscaler via a ConfigMap because scale to 0 by default might have a big latency impact

[knative-prow]

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
upgrade-tests_eventing-kafka-broker_main	408a112	link	true	/test upgrade-tests
reconciler-tests_eventing-kafka-broker_main	408a112	link	true	/test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[knative-prow-robot]

@pierDipi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Cali0707]

/cc @Cali0707

[Cali0707]

Suggested change

	# quick check - we need exactly one argument which denotes the Strimzi version we want to update to
	if [[ "$#" -ne 1 ]]; then
	echo "Usage: $0 <strimzi_version>"
	exit 1
	# quick check - we need exactly one argument which denotes the KEDA version we want to update to
	if [[ "$#" -ne 1 ]]; then
	echo "Usage: $0 <keda_version>"
	exit 1

Shouldn't these be keda versions?

[pierDipi]

Yes

[Cali0707]

Suggested change

	# Copyright 2020 The Knative Authors
	# Copyright 2023 The Knative Authors

[Cali0707]

@pierDipi can we close this PR now that #3285 is merged?

[pierDipi]

Yes, thanks @Cali0707