Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry webhook EOF errors #2484

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Aug 8, 2022

This test sometimes fails due to [1].

[1] knative/pkg#1509

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

This test sometimes fails due to [1].

[1] knative/pkg#1509

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test labels Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #2484 (d204560) into main (c7e7f5e) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2484      +/-   ##
============================================
- Coverage     64.62%   64.57%   -0.06%     
+ Complexity      711      710       -1     
============================================
  Files           146      146              
  Lines          9807     9807              
  Branches        223      223              
============================================
- Hits           6338     6333       -5     
- Misses         3037     3044       +7     
+ Partials        432      430       -2     
Flag Coverage Δ
java-unittests 81.22% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ive/eventing/kafka/broker/core/AsyncCloseable.java 66.66% <0.00%> (-13.34%) ⬇️
...dispatcher/impl/consumer/BaseConsumerVerticle.java 87.09% <0.00%> (-6.46%) ⬇️
...broker/dispatcher/impl/consumer/OffsetManager.java 94.62% <0.00%> (-1.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi pierDipi changed the title [WIP] Retry webhook EOF errors Retry webhook EOF errors Aug 8, 2022
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2022
@matzew
Copy link
Contributor

matzew commented Aug 9, 2022

/retest

@matzew
Copy link
Contributor

matzew commented Aug 9, 2022

/test integration-tests_eventing-kafka-broker_main

@knative-prow knative-prow bot merged commit 93b63bf into knative-extensions:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants