Skip to content

Commit

Permalink
edit addresses
Browse files Browse the repository at this point in the history
  • Loading branch information
Rahul-Kumar-prog committed Aug 2, 2023
1 parent a407f84 commit 8f40d2b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion control-plane/pkg/reconciler/channel/channel.go
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,8 @@ func (r *Reconciler) finalizeKind(ctx context.Context, channel *messagingv1beta1
address := receiver.HTTPAddress(r.IngressHost, channel)
proberAddressable := prober.NewAddressable{
AddressStatus: &duckv1.AddressStatus{
Address: &address,
Address: &address,
Addresses: []duckv1.Addressable{address},
},
ResourceKey: types.NamespacedName{
Namespace: channel.GetNamespace(),
Expand Down
3 changes: 2 additions & 1 deletion control-plane/pkg/reconciler/channel/v2/channelv2.go
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,8 @@ func (r *Reconciler) FinalizeKind(ctx context.Context, channel *messagingv1beta1
address := receiver.HTTPAddress(r.IngressHost, channel)
proberAddressable := prober.NewAddressable{
AddressStatus: &duckv1.AddressStatus{
Address: &address,
Address: &address,
Addresses: []duckv1.Addressable(address)

Check failure on line 425 in control-plane/pkg/reconciler/channel/v2/channelv2.go

View workflow job for this annotation

GitHub Actions / build / Build

syntax error: unexpected newline in composite literal; possibly missing comma or }

Check failure on line 425 in control-plane/pkg/reconciler/channel/v2/channelv2.go

View workflow job for this annotation

GitHub Actions / analyze / Go vulnerability Detection

missing ',' before newline in composite literal

Check failure on line 425 in control-plane/pkg/reconciler/channel/v2/channelv2.go

View workflow job for this annotation

GitHub Actions / analyze / Go vulnerability Detection

cannot convert address (variable of type "knative.dev/pkg/apis/duck/v1".Addressable) to type []"knative.dev/pkg/apis/duck/v1".Addressable

Check failure on line 425 in control-plane/pkg/reconciler/channel/v2/channelv2.go

View workflow job for this annotation

GitHub Actions / style / Golang / Auto-format and Check

missing ',' before newline in composite literal

Check failure on line 425 in control-plane/pkg/reconciler/channel/v2/channelv2.go

View workflow job for this annotation

GitHub Actions / style / Golang / Lint

missing ',' before newline in composite literal (typecheck)
},
ResourceKey: types.NamespacedName{
Namespace: channel.GetNamespace(),
Expand Down

0 comments on commit 8f40d2b

Please sign in to comment.