Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Implemented: Generic Support for Methods in UnhollowerUtils #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sewer56
Copy link

@Sewer56 Sewer56 commented May 30, 2022

This simple patch adds support for fetching Generic methods via the GetIl2CppMethodInfoPointerFieldForGeneratedMethod API inside UnhollowerUtils.

Not much to say here, no API changes.
I implemented this in order to allow 3rd party libraries such as HarmonyX (in MelonLoader) to be able to successfully hook generic methods.


[Previously GetIl2CppMethodInfoPointerFieldForGeneratedMethod would return null and generic methods were not hookable.

Copy link

@AndreLouisIssa AndreLouisIssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work and this has been a bad problem for a while, merge soon please!

@doombubbles
Copy link

Would really like to see this merged 👍

@hemisemidemipresent
Copy link

any updates about this getting merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants