Corrected loading of messengers from serverConfig on line 629 #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with v4.0, it was impossible to select any messenger besides email for a campaign due to an issue loading the messenger list from the API on line 629 of Campaign.vue. The change was making m.name be just m since the messengers are listed as an array of strings on /api/config
knadh
reviewed
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with v4.0, it was impossible to select any messenger besides email for a campaign due to an issue loading the messenger list from the API on line 629 of Campaign.vue.
The change was making m.name be just m since the messengers are listed as an array of strings on /api/config