hover on donut shows percentage #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it difficult to make it similar to the previous design where you didn't have to hover to view the numbers? Eg: #1728 (comment) |
knadh
reviewed
Oct 30, 2024
knadh
reviewed
Oct 30, 2024
|
@knadh Resolved the issues. |
|
Let me know if I have to fix anything in this PR. |
|
Thanks @Bowrna. Will test it this week and merge. |
|
Merged. Thanks! PS: Made a slight tweak and removed the custom truncated label as the tooltip shows the label in bold by default anyway.
|
My bad! it didn't strike me that label is already visible and I should have removed it rather than truncating 🫤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1728
related: #1728