Add Watch alternative to provider.File to return Watcher obj #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the watcher object can be closed and deallocated properly.
The problem this solved, is when koanf is being used with managed dependency injection and the koanf instance is deallocated and reallocated at some time in the code. In these cases the created watchers are permanent, and koanf is still triggering the callbacks on obsolet koanf instances (which already belong to the GC).
We've found this during unit testing, where each test is bringing up its own config instance along with koanf, and watcher callbacks are being called after we have "deallocated" (removed the references to, as there's no Close() or anything similar on
koanf.Koanf
) to the koanf instance belonging to the test.