WIP: feat: create document functionality + yaml support refs #143 #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstasik
force-pushed
the
feature/create-documents-and-yaml-support-143
branch
from
cfeb03b to
54a7519
Compare
kmiura-1002
reviewed
May 22, 2022
| ...resolvedMigration.query_parameters | ||
| }; | ||
|
|
||
| await esClient.postDocument(data); |
There was a problem hiding this comment.
In this process, it is not a good idea to use postDocument if the goal is to register multiple data in a loop process!
This is not suitable for registering large amounts of data.
Internally, it is just executing the Index API, so it is correct to use the Bulk API if you want to use it for your purpose.
https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CREATE_DOCUMENT + yaml support.
resolves #143