More flexible charts #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like "aggregate" change, and values_count option looks useful (esp. when passed to constructor). It doesn't make much sense to display 30-year stats by default, and for me 12 months looks better than 30 months, but these are minor details and they are easy to change in user code. So I'm going to merge your pull request. Would you mind adding yourself to https://github.com/kmike/django-admin-user-stats/blob/master/AUTHORS.rst ? Thanks! |
|
Oh, I forgot this. I added myself now to authors. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two patches allowing to set aggregate and number of displayed values for BaseChart and view by year.