Skip to content

Match gemspec files explicitly #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

brianclinkenbeard
Copy link

@brianclinkenbeard brianclinkenbeard commented Jul 8, 2025

Solves #8 (regression from a4ef785).

This includes the files we want to package explicity, removing the files below from the package.

diff of included files
$ diff old-files-sorted new-files-sorted
16,22d15
< exception_notification.gemspec
< Gemfile
< Gemfile.lock
< gemfiles/pinned_dependencies.gemfile
< gemfiles/rails7_1.gemfile
< gemfiles/rails7_2.gemfile
< gemfiles/rails8_0.gemfile
68,90d60
< test/exception_notification/rack_test.rb
< test/exception_notification/rake_test.rb
< test/exception_notification/resque_test.rb
< test/exception_notifier/datadog_notifier_test.rb
< test/exception_notifier/email_notifier_test.rb
< test/exception_notifier/google_chat_notifier_test.rb
< test/exception_notifier/hipchat_notifier_test.rb
< test/exception_notifier/irc_notifier_test.rb
< test/exception_notifier/mattermost_notifier_test.rb
< test/exception_notifier/modules/error_grouping_test.rb
< test/exception_notifier/modules/formatter_test.rb
< test/exception_notifier/sidekiq_test.rb
< test/exception_notifier/slack_notifier_test.rb
< test/exception_notifier/sns_notifier_test.rb
< test/exception_notifier/teams_notifier_test.rb
< test/exception_notifier_test.rb
< test/exception_notifier/webhook_notifier_test.rb
< test/support/exception_notifier_helper.rb
< test/support/views/exception_notifier/_new_bkg_section.html.erb
< test/support/views/exception_notifier/_new_bkg_section.text.erb
< test/support/views/exception_notifier/_new_section.html.erb
< test/support/views/exception_notifier/_new_section.text.erb
< test/test_helper.rb

@brianclinkenbeard brianclinkenbeard force-pushed the match-gemspec-files-explicitly branch from b281f7f to 85b27a0 Compare July 8, 2025 20:34
@brianclinkenbeard
Copy link
Author

@kmcphillips Sorry to ping, would appreciate your review on this since anyone using AWS Inspector may get alerts due to the included lockfile.

@kmcphillips
Copy link
Owner

Hello! No need to be sorry. I've been on summer holiday but I can look at this in the next couple days. Thanks for opening this.

@kmcphillips
Copy link
Owner

Ok this looks pretty good. But I'm pretty sure it should not reject the .gemspec file. I'll pull it down and fix that and do the diff myself to be sure.

Copy link
Owner

@kmcphillips kmcphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting on this. I pulled the branch down and got the same diff as you.

One comment. Then I can merge it and I'll release a minor version.

Co-authored-by: Kevin McPhillips <github@kevinmcphillips.ca>
@brianclinkenbeard
Copy link
Author

@kmcphillips Done! Thanks for taking a look at this.

@kmcphillips kmcphillips merged commit edbfd81 into kmcphillips:main Aug 3, 2025
16 checks passed
@kmcphillips
Copy link
Owner

Thank you for your contribution.

@kmcphillips
Copy link
Owner

Released in 5.0.1 https://github.com/kmcphillips/exception_notification/releases/tag/v5.0.1

@brianclinkenbeard brianclinkenbeard deleted the match-gemspec-files-explicitly branch August 3, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants