Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to running on iOS 13 #70

Merged
merged 3 commits into from
Sep 27, 2019
Merged

Fixes to running on iOS 13 #70

merged 3 commits into from
Sep 27, 2019

Conversation

gildaswise
Copy link
Contributor

  • On current version the app just doesn't build because of some compatibility/deprecated issues on iOS 13
  • Also re-ran flutter create . on the example folder, somehow couldn't run it locally
  • Updated Dart sdk requirement to 2.1.0

@YoussefKababe
Copy link
Collaborator

YoussefKababe commented Sep 25, 2019 •
edited
Loading

@kmcgill88 Since you worked on iOS support, can you please take a look? 🙏

kmcgill88
kmcgill88 approved these changes Sep 27, 2019
View reviewed changes
Copy link
Owner

@kmcgill88 kmcgill88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't pull this down and run it but, LGTM

@YoussefKababe YoussefKababe merged commit ae285f1 into kmcgill88:master Sep 27, 2019
@YoussefKababe
Copy link
Collaborator

@gildaswise @kmcgill88 Awesome, thank you so much! Published under 0.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmcgill88 kmcgill88 kmcgill88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gildaswise @YoussefKababe @kmcgill88