This repository was archived by the owner on Jan 25, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
API documentation with Swagger #24
Merged
JakobMiksch
merged 14 commits into
klips-project:main
from
JakobMiksch:swagger-api-2022-09-09
Sep 14, 2022
Merged
API documentation with Swagger #24
JakobMiksch
merged 14 commits into
klips-project:main
from
JakobMiksch:swagger-api-2022-09-09
Sep 14, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
hwbllmnn
approved these changes
Sep 9, 2022
hblitza
reviewed
Sep 14, 2022
README.md
Outdated
| @@ -11,16 +11,6 @@ with local Node.js: | |||
| npm i | |||
|
|
|||
| # define environment variables and run | |||
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment define environment variables still needed? since below all are deleted
hblitza
approved these changes
Sep 14, 2022
Contributor
hblitza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor.
This was referenced Sep 14, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/docswith a Swagger UI for API development, see screenshot below/docsdoes not need Basic Auth, the API routes still need itTODO (After merge)
swagger.yamlis currently redundant with our JSON schemaschema-geotiff-upload.json- we should find a way to either link the JSON schema to the Swagger config or use the swagger config to validate the input of the API --> could be moved to follow up issue