Python 3 compatiblity #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
force-pushed
the
py3k
branch
3 times, most recently
from
faad825
to
554d7ca
Compare
|
This mostly works for me, but I still haven't tried to print anything. That has to wait for tmrw. I'm still expecting to be bitten by more true division and bytes vs str mishmashs. |
hroncok
force-pushed
the
py3k
branch
5 times, most recently
from
4e6f674
to
6a7f10e
Compare
|
I can print! |
hroncok
force-pushed
the
py3k
branch
2 times, most recently
from
d5dcf9d
to
8f6f183
Compare
Change generated by:
python-modernize -wnf lib2to3.fixes.fix_except
Change generated by:
python-modernize -wnf lib2to3.fixes.fix_print
Changed manually
Change generated by:
python-modernize -wnf lib2to3.fixes.fix_tuple_params
And fixed up manually.
Change generated by:
python-modernize -wnf lib2to3.fixes.fix_import
Change generated by:
python-modernize -wnf lib2to3.fixes.fix_imports
Instead, make sure the encoding of our locale is UTF-8
Initialy converted by:
python-modernize -wnf lib2to3.fixes.fix_map
Went trough the changes manually, used comprehensions where possible.
Initialy converted by:
python-modernize -wnf lib2to3.fixes.fix_filter
Done manual changes.
Initially done by:
python-modernize -wnf lib2to3.fixes.fix_unicode
Removed the u"" -> "" change.
Change generated by:
python-modernize -wnf lib2to3.fixes.fix_exec
Initally fixed by:
find printrun -name '*.py' -type f -exec bash -c 'T=$(mktemp); expand -i -t 8 "$0" > "$T" && mv "$T" "$0"' {} \;
Then fixed printrun/serialWrapper.py manually from 8 spaces indent to 4.
Initially with:
python-modernize -wnf lib2to3.fixes.fix_xrange
Went trough the changes and removed some unnecessary.
Done manually, the fixer didn't work.
By:
python-modernize -wnf lib2to3.fixes.fix_itertools
Removed unused itertools import manually.
Fixed by:
python-modernize -wnf lib2to3.fixes.fix_raw_input
Fixed by:
python-modernize -wnf lib2to3.fixes.fix_next
Initially by:
python-modernize -wnf lib2to3.fixes.fix_dict
Manually removed where not needed.
Manually, see [1] for explanation. [1]: https://portingguide.readthedocs.io/en/latest/builtins.html#removed-execfile
Converted automatically by:
python-modernize -wnf lib2to3.fixes.fix_idioms
Initially by:
python-modernize -wnf lib2to3.fixes.fix_reduce
Then reorganized the import a bit manually.
Automated by:
python-modernize -wnf lib2to3.fixes.fix_set_literal
Automatically by:
python-modernize -wnf lib2to3.fixes.fix_unicode
This fixer also renames unicode to str, which was done before.
Done by:
sed -i 's/(object):/:/g' $(git grep --name-only '(object)')
Also, import it properly, as it was not cythonized before and was not caught by the lib2to3 import fixer.
* convert to python3 * only have shebangs + exec bits in files that have something to execute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #882
Depends on #886