Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change locale of objectplater.py from plater.pot to pronterface.pot #1343

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

DivingDuck
Copy link
Collaborator

I thought I did this already, but I didn't...
the idea is to get rid of needing two individual translation files. I did already add all translations strings to file pronterface.pot when we released v 2.0.0. I would suggest to leave the not longer needed plater.pot file for some time available in the repository so that users of prior versions have still access for a while.
c8c2b51

I updated the Windows build script so that it is able to build the binary for Plater as well. In addition some clean-up like removal of the comments for the wxPython workaround as this is no longer needed.
67b8ba5

echo ****** Build Pronterface and Pronsole executables ******
echo ********************************************************
echo ***************************************************************
echo ****** Build Pronterface, Pronsole an Plater executables ******
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*and

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh....

Copy link
Collaborator

@rockstorm101 rockstorm101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge, I'm just wondering out loud on these ones.

release_windows.bat Show resolved Hide resolved
release_windows.bat Show resolved Hide resolved
@rockstorm101 rockstorm101 merged commit 63ae993 into kliment:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants