Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look in imagefile and pixmap paths as created by pip #1285

Merged
merged 5 commits into from
Sep 11, 2022

Conversation

Poikilos
Copy link
Contributor

@Poikilos Poikilos commented Aug 25, 2022

(Fix #1284 ). Also, use lookup_file in the imagefile function, and add related documentation (PEP8 documentation plus returns).

(Fix kliment#1248). Also, use lookup_file in the imagefile function, and add related documentation (PEP8 documentation plus returns).
@kliment
Copy link
Owner

kliment commented Aug 25, 2022

Is this ready for review or do you still plan to add more commits?

@Poikilos
Copy link
Contributor Author

This is ready for review.

@kliment
Copy link
Owner

kliment commented Aug 25, 2022

@DivingDuck @hroncok @a2k-hanlon @rockstorm101 @volconst any objections to this? I'm ready to merge it.

@rockstorm101
Copy link
Collaborator

@DivingDuck @hroncok @a2k-hanlon @rockstorm101 @volconst any objections to this? I'm ready to merge it.

I'm happy with this PR. Thanks a lot @Poikilos. Great thing you documented this.

@volconst
Copy link
Collaborator

volconst commented Aug 26, 2022

@DivingDuck @hroncok @a2k-hanlon @rockstorm101 @volconst any objections to this? I'm ready to merge it.

No objections

@DivingDuck
Copy link
Collaborator

DivingDuck commented Aug 29, 2022 via email

@DivingDuck
Copy link
Collaborator

Hi @kliment ,
sorry for the delay. I'm happy with this PR too. Well done documentation. Thanks a lot @Poikilos.

@kliment
Copy link
Owner

kliment commented Sep 11, 2022

I think we have enough consensus to merge this now. I'll do that. Thank you for your contribution @Poikilos !

@kliment kliment merged commit e60a93f into kliment:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wx._core.wxAssertionError: C++ assertion ""image.IsOk()"" failed when installed using pip
5 participants