-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look in imagefile and pixmap paths as created by pip #1285
Conversation
(Fix kliment#1248). Also, use lookup_file in the imagefile function, and add related documentation (PEP8 documentation plus returns).
Is this ready for review or do you still plan to add more commits? |
This is ready for review. |
@DivingDuck @hroncok @a2k-hanlon @rockstorm101 @volconst any objections to this? I'm ready to merge it. |
I'm happy with this PR. Thanks a lot @Poikilos. Great thing you documented this. |
No objections |
Hi all,
Kliment, sorry for my late answer. I’m on a travel and have no possibility to take a look on this until end next week and there is a mostly tech free zone at our sailing trip 😊. Please don’t wait for me if the change is ok for you all. I will look on this when I’m back
Best regards,
Armin
|
I think we have enough consensus to merge this now. I'll do that. Thank you for your contribution @Poikilos ! |
(Fix #1284 ). Also, use lookup_file in the imagefile function, and add related documentation (PEP8 documentation plus returns).