Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docs and readme #10

Closed
wants to merge 2 commits into from
Closed

feat: add docs and readme #10

wants to merge 2 commits into from

Conversation

zw0610
Copy link
Contributor

@zw0610 zw0610 commented Nov 29, 2019

What this PR does / why we need it:

Adding design doc as well as readme and license.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #9

Reference to #

Special notes for your reviewer:

/cc @terrytangyuan @gaocegege @pendoragon @ddysher

Release note:

NONE

@caicloud-bot caicloud-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 29, 2019
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gaocegege

Assign the PR to them by writing /assign @gaocegege in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 29, 2019
@caicloud-bot
Copy link

@zw0610: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zw0610 zw0610 changed the title WIP feat: add docs and readme feat: add docs and readme Nov 29, 2019
@caicloud-bot caicloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2019
@ddysher
Copy link
Member

ddysher commented Nov 30, 2019

There's nothing in the commit, which is probably caused by opensourcing the repository.

@ddysher
Copy link
Member

ddysher commented Nov 30, 2019

BTW, we should include a license file, ref https://github.com/caicloud/cyclone/blob/master/LICENSE

Wang Zhang added 2 commits November 30, 2019 15:13
@caicloud-bot caicloud-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 30, 2019
@zw0610
Copy link
Contributor Author

zw0610 commented Nov 30, 2019

There's nothing in the commit, which is probably caused by opensourcing the repository.

Yes, I re-forked the repo and it looks working. I'll check with @bbbmj to make sure the needs-rebase tag removed.

@zw0610
Copy link
Contributor Author

zw0610 commented Nov 30, 2019

/close the public process broke configuration of this pr. replaced by #11

@zw0610 zw0610 closed this Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide design doc
3 participants