You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are deploying upgradable proxies and we want the proxy to have a deterministic address.
But while testing, we can see that the proxy's address would change depending on the implementation's initializer's parameters. We understand where the problem is coming from but not entirely sure about the best solution.
PR-Codex overview
The focus of this PR is to refactor contracts and scripts related to arbitration and staking, update deployment functions, and improve contract initialization.
Detailed summary
Renamed and updated functions in SortitionModuleBase, SortitionModule, and SortitionModuleNeo.
Added _deployer parameter in TestERC20 constructor.
Adjusted deployment scripts to support deterministic deployments.
Updated initialization functions in KlerosCore and KlerosCoreNeo.
Modified deployment functions in deployTokens.ts and 00-home-chain-arbitrable.ts.
Enhanced network configurations in hardhat.config.ts.
Updated package.json scripts for devnet and testnet forks.
The following files were skipped due to too many changes: contracts/src/arbitration/KlerosCoreBase.sol, contracts/deploy/00-home-chain-arbitration-neo.ts, contracts/deploy/utils/deployUpgradable.ts, contracts/src/arbitration/arbitrables/DisputeResolver.sol, contracts/deploy/00-home-chain-arbitration.ts, yarn.lock
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.
Generate unit testing code for this file.
Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
@coderabbitai generate unit testing code for this file.
@coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
@coderabbitai generate interesting stats about this repository and render them as a table.
@coderabbitai show all the console.log statements in this repository.
@coderabbitai read src/utils.ts and generate unit testing code.
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jaybuidl
added
Type: Enhancement ✨
Compatibility: ABI change 🗯
[WIP]
Known issue currently
We are deploying upgradable proxies and we want the proxy to have a deterministic address.
But while testing, we can see that the proxy's address would change depending on the implementation's initializer's parameters. We understand where the problem is coming from but not entirely sure about the best solution.
PR-Codex overview
The focus of this PR is to refactor contracts and scripts related to arbitration and staking, update deployment functions, and improve contract initialization.
Detailed summary
SortitionModuleBase,SortitionModule, andSortitionModuleNeo._deployerparameter inTestERC20constructor.KlerosCoreandKlerosCoreNeo.deployTokens.tsand00-home-chain-arbitrable.ts.hardhat.config.ts.