Skip to content

docs: updated deployment addresses #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Conversation

jaybuidl
Copy link
Member

@jaybuidl jaybuidl commented Aug 1, 2022

Added more contracts.
Added Goerli as the new favorite testnet.

@jaybuidl jaybuidl self-assigned this Aug 1, 2022
@jaybuidl jaybuidl requested a review from gmkung August 1, 2022 17:22
Copy link

@xpriment626 xpriment626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployment-addresses: line 60 - Points to PNK Faucet deployment instead of PNK token deployment

Other than that this looks great, much more organised and comprehensive.

@jaybuidl
Copy link
Member Author

jaybuidl commented Aug 2, 2022

line 60 - Points to PNK Faucet deployment instead of PNK token deployment

Fixed. Actually the error comes from the existing documentation 🤦‍♂️
https://github.com/kleros/kleros-docs/blob/master/developer/deployment-addresses.md?plain=1#L16

Copy link

@xpriment626 xpriment626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@jaybuidl jaybuidl merged commit a2046c9 into master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants