You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The aioauth-client is using aiohttp without the max version being pinned. This is potentially pretty unstable, since aioauth-client is also using deprecated apis.
async def _request(self, method, url, loop=None, timeout=None, **kwargs):
"""Make a request through AIOHTTP."""
session = self.session or aiohttp.ClientSession(
loop=loop, conn_timeout=timeout, read_timeout=timeout, raise_for_status=True)
try:
async with session.request(method, url, **kwargs) as response:
if 'json' in response.headers.get('CONTENT-TYPE'):
data = await response.json()
else:
data = await response.text()
data = dict(parse_qsl(data)) or data
return data
except asyncio.TimeoutError:
raise web.HTTPBadRequest(reason='HTTP Timeout')
finally:
if not self.session and not session.closed:
await session.close()
These are slated to be removed in aiohttp 4.0.0 and once that package is released, aioauth-client users will be in a broken state due to the lack of maximum version pinning.
Can the maximum version be capped and/or the deprecated features be removed and replaced with a single timeout?
The text was updated successfully, but these errors were encountered:
This library has changed its purpose and is now uses `httpx`, so it's no
longer compatible with `aiohttp`.
This is only clarified here: klen/aioauth-client#168
Hi,
The aioauth-client is using aiohttp without the max version being pinned. This is potentially pretty unstable, since aioauth-client is also using deprecated apis.
The requirements.txt (used in setup.py)
Per
https://docs.aiohttp.org/en/stable/changes.html#deprecations-and-removals several of the timeout arguments used in aioauth-client are marked as deprecated and do raise DeprecationWarning notices. These are here https://github.com/klen/aioauth-client/blob/develop/aioauth_client.py#L147
These are slated to be removed in aiohttp 4.0.0 and once that package is released, aioauth-client users will be in a broken state due to the lack of maximum version pinning.
Can the maximum version be capped and/or the deprecated features be removed and replaced with a single timeout?
The text was updated successfully, but these errors were encountered: