Skip to content

Add {{path}} parsing to 'start-' and 'endtag' #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 20, 2016

Conversation

meeroslav
Copy link
Contributor

Now we can target specific files to inject based on their file path.
Works in alignment with 'relative' param to detect relative path from destination file.

This was added for easier partials loading in big application, with avoiding the need to have complex config structures.


##### Default:

A function dependent on target file type and source file type that returns:

* html as target: `<!-- {{name}}:{{ext}} -->`
* html as path: `<!-- {{path}} -->`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't be here. This lists the default tags for different target file types.
A complete usage example in the example section would be great!

@joakimbeng
Copy link
Member

Great, thanks!
See my comments for some small changes, otherwise it's LGTM!

@meeroslav
Copy link
Contributor Author

Thanks for your quick reply. Please check my latest commit to verify readme file.

@okeegan
Copy link

okeegan commented Dec 5, 2016

@joakimbeng any chance we could get this merged in?

@joakimbeng
Copy link
Member

Great job! Thanks :)

Also please don't hesitate in asking for being a collaborator, I need help maintaining this repo :)

@joakimbeng joakimbeng merged commit f72d494 into klei:master Dec 20, 2016
@meeroslav
Copy link
Contributor Author

I'll try to help whenever I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants