Skip to content

[codex] Fix Nexus ALL action permission matching#73

Merged
klboke merged 2 commits into
mainfrom
codex/nexus-all-action-permissions
Jul 3, 2026
Merged

[codex] Fix Nexus ALL action permission matching#73
klboke merged 2 commits into
mainfrom
codex/nexus-all-action-permissions

Conversation

@klboke

@klboke klboke commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Treat Nexus repository privilege action ALL as a wildcard during permission matching.
  • Normalize Nexus action aliases only in the permission action segment: ALL -> *, create -> add, and update -> edit.
  • Add regression coverage for migrated Nexus repository-view privileges and application action aliases.

Root Cause

Nexus exposes generated nx-repository-view-<format>-<repo>-* privileges with action ALL. kkRepo normalized newly created REST privileges to *, but existing or migrated records that still stored ALL were compared literally, so write/delete permissions could be denied even though Nexus grants them.

Validation

  • mvn -pl server -am -Dtest=SecurityManagementServicePermissionTest -Dsurefire.failIfNoSpecifiedTests=false test
  • git diff --check
  • Live checked local Nexus 28090: nx-repository-view-maven2-maven-dcmes-* and nx-repository-view-maven2-team-dcmes-maven-group-* use ALL and cover the concrete actions.
  • Live checked kkRepo 18090: a temp user with only an existing actions: "ALL" repository-view privilege could PUT, GET, browse, and DELETE Maven content.

Fixes #67

@klboke klboke marked this pull request as ready for review July 3, 2026 09:10
Copilot AI review requested due to automatic review settings July 3, 2026 09:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@klboke

klboke commented Jul 3, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@klboke klboke added run-live-compat Trigger live compatibility workflow run-docker-oci-conformance Trigger Docker OCI conformance workflow run-client-e2e run-migration-e2e labels Jul 3, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb9994bd6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@klboke klboke merged commit a7a77e9 into main Jul 3, 2026
11 checks passed
@klboke klboke deleted the codex/nexus-all-action-permissions branch July 3, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-client-e2e run-docker-oci-conformance Trigger Docker OCI conformance workflow run-live-compat Trigger live compatibility workflow run-migration-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nexus角色权限配置复杂化问题

2 participants