Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce allocations in flate decompressor and minor code improvements #869

Merged
merged 11 commits into from
Oct 10, 2023
Merged

Reduce allocations in flate decompressor and minor code improvements #869

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6a1c1c6
made f.step an enum instead of func pointer
flrdv Oct 8, 2023
1203209
removed useless array-to-slice conversion
flrdv Oct 8, 2023
a4773a9
made benchmarks more accurate by removing io.Copy call
flrdv Oct 8, 2023
c127997
removed useless operation of nulling the length of the slice
flrdv Oct 8, 2023
98e21c7
moved b.StartTimer() to the bottom
flrdv Oct 8, 2023
4c8d7a2
replaced indirect decoder call with direct
flrdv Oct 8, 2023
e40efbf
removed somehow commented code
flrdv Oct 9, 2023
d517f8e
moved execution of next step into the dedicated method
flrdv Oct 9, 2023
fbb9795
copying zeros into chunks instead of iterating over it and setting ma…
flrdv Oct 9, 2023
863cd97
added panic in case of unknown step state, brought old way to zero ch…
flrdv Oct 9, 2023
1248009
rollback to io.Copy
flrdv Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
made benchmarks more accurate by removing io.Copy call 
as io.Copy is just an alias for io.CopyBuffer, but passing nil instead of the actual buffer, it is being allocated internally. So better to pass it manually
  • Loading branch information
@flrdv
flrdv committed Oct 8, 2023
commit a4773a95c30044de0082747b2319dfcba3f7b7e1
4 changes: 3 additions & 1 deletion flate/reader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,15 @@ func benchmarkDecode(b *testing.B, testfile, level, n int) {
w.Close()
buf1 := compressed.Bytes()
buf0, compressed, w = nil, nil, nil
const ioCopyBuffSize = 32 * 1024 // taken from io.copyBuffer, in case passed buf==nil
ioCopyBuff := make([]byte, ioCopyBuffSize)
runtime.GC()
b.StartTimer()
r := NewReader(bytes.NewReader(buf1))
res := r.(Resetter)
for i := 0; i < b.N; i++ {
res.Reset(bytes.NewReader(buf1), nil)
io.Copy(io.Discard, r)
io.CopyBuffer(io.Discard, r, ioCopyBuff)
}
}

Expand Down