Use GHA workflow to publish pre-built images to ghcr.io #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… - utilise a matrix. If action is triggered by a pull request - it will just build the images and do nothing with them. If it is triggered by a tag, then it will publish the image to the repository owner's container registry - Some tweaks to the dockerfiles for slight reduction in overall image size by clearing apt cache and adding --no-install-recommends - Additons to `catalina-wrapper.sh` to check that the TOMCAT_ADMIN_PASSWORD is not blank (in which case it must be passed in on container start), and an additional variable to allow skipping of the 60 second sleep (useful if database is external and already running) Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes as discussed in #57
I've kept this separate from the changes proposed in #58 - but they should merge in together without conflicts as neither touch the same lines (have merging both branches into master locally)
catalina-wrapper.shto check that theTOMCAT_ADMIN_PASSWORDis not blank (in which case it must be passed in on container start), and an additional variable to allow skipping of the 60 second sleep (useful if database is external and already running)