Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with watermeter requests #233

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Conversation

klaasnicolaas
Copy link
Owner

@klaasnicolaas klaasnicolaas commented Sep 21, 2022

Old versions of P1 Monitor give a 404 when you make a request for the water meter data, newer versions give an empty list [].

@klaasnicolaas klaasnicolaas added the bugfix Fixing a bug. label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 95.62% // Head: 95.68% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (6e89f43) compared to base (6242217).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   95.62%   95.68%   +0.06%     
==========================================
  Files           3        3              
  Lines         137      139       +2     
  Branches       19       20       +1     
==========================================
+ Hits          131      133       +2     
  Misses          3        3              
  Partials        3        3              
Impacted Files Coverage Δ
p1monitor/p1monitor.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@klaasnicolaas
Copy link
Owner Author

I only fail writing extra tests for the exception, no matter what I try I don't get in the ClientResponseError :(

@klaasnicolaas
Copy link
Owner Author

For now I'm converting this to a draft

@klaasnicolaas klaasnicolaas marked this pull request as draft October 18, 2022 12:30
@klaasnicolaas klaasnicolaas marked this pull request as ready for review November 4, 2022 17:25
@klaasnicolaas klaasnicolaas merged commit ffd43f3 into main Nov 4, 2022
@klaasnicolaas klaasnicolaas deleted the fix/watermeter-404 branch February 9, 2023 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Fixing a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants