-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with watermeter requests #233
Conversation
Codecov ReportBase: 95.62% // Head: 95.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 95.62% 95.68% +0.06%
==========================================
Files 3 3
Lines 137 139 +2
Branches 19 20 +1
==========================================
+ Hits 131 133 +2
Misses 3 3
Partials 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
I only fail writing extra tests for the exception, no matter what I try I don't get in the ClientResponseError :( |
65886a8
to
6404117
Compare
For now I'm converting this to a draft |
Old versions of P1 Monitor give a 404 when you make a request for the water meter data, newer versions give an empty list
[]
.