Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

[KGA-72] fix: return uncapped return_data_len from execute_from_outside #1612

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 15, 2024

code-423n4/2024-09-kakarot-findings#24

The event is emitted with at most 297 felts of response_len, but the function returns the full data.


This change is Reviewable

Copy link

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.7%. Comparing base (0fbea3a) to head (82f0799).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1612     +/-   ##
=======================================
- Coverage   63.7%   63.7%   -0.1%     
=======================================
  Files         44      44             
  Lines       8362    8366      +4     
=======================================
- Hits        5332    5330      -2     
- Misses      3030    3036      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementWalter ClementWalter merged commit 5cdbb52 into main Nov 15, 2024
16 checks passed
@ClementWalter ClementWalter deleted the fix/returndata-len-exec-from-outside branch November 15, 2024 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants