Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KGA-106] [KGA-79] [KGA-89] dev: remove useless computation in uint256_fast_exp" #1603

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 12, 2024

https://github.com/code-423n4/2024-09-kakarot-findings/issues/2

removes a useless line that compute uint256_fast_exp one too many times.


This change is Reviewable

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.6%. Comparing base (474951c) to head (c98794a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1603     +/-   ##
=======================================
- Coverage   63.6%   63.6%   -0.1%     
=======================================
  Files         44      44             
  Lines       8332    8331      -1     
=======================================
- Hits        5301    5299      -2     
- Misses      3031    3032      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementWalter ClementWalter merged commit 8eacec6 into main Nov 12, 2024
16 checks passed
@ClementWalter ClementWalter deleted the dev/remove-useless-computatino branch November 12, 2024 08:42
@enitrat enitrat changed the title [KGA-89] dev: remove useless computation in uint256_fast_exp" [KGA-79] [KGA-89] dev: remove useless computation in uint256_fast_exp" Nov 13, 2024
Copy link

@enitrat enitrat changed the title [KGA-79] [KGA-89] dev: remove useless computation in uint256_fast_exp" [KGA-106] [KGA-79] [KGA-89] dev: remove useless computation in uint256_fast_exp" Nov 15, 2024
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants