Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

dev: fix ssj ci resources #1599

Merged

Conversation

vitaliypopel
Copy link
Contributor

@vitaliypopel vitaliypopel commented Nov 9, 2024

Fixed bug in kakarot_scripts/check_resources.py with wrong and not needed parameter.

Time spent on this PR:
0.1 day (2-3 hours)

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1597

What is the new behavior?

  • make check-resources now works without any bugs.

This change is Reviewable

@ClementWalter
Copy link
Member

@vitaliypopel
image
see the error, it's fine for this time but please do the config (otherwise anyone can impersonate you)

@ClementWalter ClementWalter merged commit f87b89e into kkrt-labs:main Nov 9, 2024
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(ssj): fix resources CI [1]
2 participants