-
Notifications
You must be signed in to change notification settings - Fork 323
feat: Updated the Pragma Caller contract #1506
Conversation
The solidity version of the contract should be fixed ex: 0.8.27 |
Done ; although there's multiple contract files using: pragma solidity >=0.7.0 <0.9.0; |
Those not using a fixed version are not production contract |
tests/end_to_end/CairoPrecompiles/Pragma/test_pragma_precompile.py
Outdated
Show resolved
Hide resolved
ill come back to this soon, right after #1510 |
f682e60
to
6577048
Compare
All green now; anything else to change? |
@enitrat Everything's good - thanks a lot! |
d8c3ee0
to
2d6874a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - @obatirou all good on the sol contracts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we should probably add some extra tests for new entrypoints
yes missing tests for new entrypoints and it seems the build does not pass again with the same error. |
Adding the tests asap - sry for the delay, pretty busy with other stuff. 🫡 |
@akhercha are you able to rebase and fix? |
need to change the |
Hopefully fixed soon - sorry for the delay |
ed067b9
to
4f7e05a
Compare
Time spent on this PR:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #NA
What is the new behavior?
PragmaCaller
now callsget_data
withAggregationMode
SummaryStats
contract calls for Pragma computational feedsget_data
&MockPragmaSummaryStats
contractThis change is