Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

feat: Updated the Pragma Caller contract #1506

Merged
merged 38 commits into from
Nov 1, 2024

Conversation

akhercha
Copy link
Contributor

@akhercha akhercha commented Oct 13, 2024

Time spent on this PR:

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #NA

What is the new behavior?

  • PragmaCaller now calls get_data with AggregationMode
  • Added the SummaryStats contract calls for Pragma computational feeds
  • Updated tests with get_data & MockPragmaSummaryStats contract

This change is Reviewable

@akhercha akhercha requested a review from obatirou October 14, 2024 14:17
@obatirou
Copy link
Collaborator

The solidity version of the contract should be fixed ex: 0.8.27

@akhercha
Copy link
Contributor Author

The solidity version of the contract should be fixed ex: 0.8.27

Done ; although there's multiple contract files using:

pragma solidity >=0.7.0 <0.9.0;

@obatirou
Copy link
Collaborator

obatirou commented Oct 14, 2024

The solidity version of the contract should be fixed ex: 0.8.27

Done ; although there's multiple contract files using:

pragma solidity >=0.7.0 <0.9.0;

Those not using a fixed version are not production contract

@enitrat
Copy link
Collaborator

enitrat commented Oct 16, 2024

ill come back to this soon, right after #1510

@enitrat enitrat force-pushed the feat/pragma_caller branch from f682e60 to 6577048 Compare October 17, 2024 20:04
@enitrat
Copy link
Collaborator

enitrat commented Oct 18, 2024

All green now; anything else to change?

@akhercha
Copy link
Contributor Author

@enitrat Everything's good - thanks a lot!

@enitrat enitrat force-pushed the feat/pragma_caller branch from d8c3ee0 to 2d6874a Compare October 18, 2024 12:51
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @obatirou all good on the sol contracts?

Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually we should probably add some extra tests for new entrypoints

@obatirou
Copy link
Collaborator

actually we should probably add some extra tests for new entrypoints

yes missing tests for new entrypoints and it seems the build does not pass again with the same error.

@akhercha
Copy link
Contributor Author

Adding the tests asap - sry for the delay, pretty busy with other stuff. 🫡

@ClementWalter
Copy link
Member

@akhercha are you able to rebase and fix?

@ClementWalter
Copy link
Member

need to change the .tool-versions I guess

@akhercha
Copy link
Contributor Author

Hopefully fixed soon - sorry for the delay

@akhercha
Copy link
Contributor Author

@enitrat @obatirou should be good!

@akhercha akhercha requested review from enitrat and obatirou October 30, 2024 13:13
@enitrat enitrat force-pushed the feat/pragma_caller branch from ed067b9 to 4f7e05a Compare October 31, 2024 04:03
enitrat
enitrat previously approved these changes Oct 31, 2024
@enitrat enitrat merged commit 6cbc820 into kkrt-labs:main Nov 1, 2024
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants