Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

feat: unpack packed calldata #1178

Merged
merged 8 commits into from
Jun 6, 2024
Merged

feat: unpack packed calldata #1178

merged 8 commits into from
Jun 6, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Jun 4, 2024

Time spent on this PR: 1.3d

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1175

What is the new behavior?


This change is Reviewable

Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should just reused what exists in accounts.library for loading stored packed bytecode

calldata be encoded as

calldata[0] is bytecode_len
calldata + 1 is stored packed bytecode

and should work

@enitrat enitrat force-pushed the feat/unpack-calldata branch 2 times, most recently from 41485d8 to 78a79a5 Compare June 5, 2024 14:13
@enitrat enitrat marked this pull request as ready for review June 5, 2024 16:53
@enitrat enitrat force-pushed the feat/unpack-calldata branch from d89aeac to 7d880f7 Compare June 6, 2024 10:05
@ClementWalter ClementWalter merged commit 5c1e920 into main Jun 6, 2024
7 checks passed
@ClementWalter ClementWalter deleted the feat/unpack-calldata branch June 6, 2024 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: unpack transaction calldata
2 participants