This repository was archived by the owner on Jan 9, 2025. It is now read-only.
fix: addmod #1170
Merged
fix: addmod #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+252
to
+254
| // result = (2**256) - (n - overflown_sum) | ||
| // <=> result = (2**256 - 1) - (n - overflown_sum - 1) | ||
| // as n > overflown_sum we can't have an underflow |
There was a problem hiding this comment.
this is not so easy to follow.
You could
let a = popped[0]
let b = popped[1]
let n = popped[2]
then using your notations (the names of the variable)
result = 2**256 * carry + sum = 2**256 + sum
= 2**256 + sum - n = 2**256 - 1 - n + sum + 1
and this is because carry > 0 => n > 2**128 so 2**256 mod n = 2**256 - n
ClementWalter
approved these changes
Jun 3, 2024
matthieuauger
pushed a commit
to matthieuauger/kakarot
that referenced
this pull request
Nov 9, 2024
* dev: move TRANSACTION_MAX_RETRIES to env * undo to pub access identifier * applied suggestions from code review * fixed linting issues --------- Co-authored-by: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.5d
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #
What is the new behavior?
addmodwhere if (a+b) overflowed, the carry was not handledThis change is