This repository was archived by the owner on Jan 9, 2025. It is now read-only.
Tests/improve auth tests #1139
Merged
Tests/improve auth tests #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@enitrat The approach to set the authority is a makeshift one as I thought I should first make a PR with the draft and continue from there. I will leave some comments in the code where I found some issues. |
enitrat
force-pushed
the
tests/improve_AUTH_tests
branch
2 times, most recently
from
116afa0 to
8d1fb93
Compare
seperated the method of test__auth in test_system_operations.cairo into two methods. one which initializes evm with authority as set and other with authority unset taking a scaffolding pathway. made relevant changes to the python file. added a method in helpers.cairo to initialize an evm frame with authority set. updated readme to reflect correct command for testing units which was likely a typo.
enitrat
force-pushed
the
tests/improve_AUTH_tests
branch
from
8d1fb93 to
389439d
Compare
enitrat
force-pushed
the
tests/improve_AUTH_tests
branch
from
817c265 to
5ec0ba3
Compare
matthieuauger
pushed a commit
to matthieuauger/kakarot
that referenced
this pull request
Nov 9, 2024
* chore: add kakarot address to staging docker * fix staging compose
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 3-4 days
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The authority is unset in the initial frame when the exec_auth is being called.
Resolves #1121
What is the new behavior?
This change is