This repository was archived by the owner on Jan 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementWalter
suggested changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you miss a poetry add vyper
somewhere, and also don't all contracts we don't use, only the one we need (3074InvokePoc
I guess) and fix case in naming
possibly also add a readme or command in the makefile to actually compile these files
Tested against katana with this script import os
os.environ["STARKNET_NETWORK"] = "katana"
from kakarot_scripts.utils.kakarot import *
eip3074 = await deploy("EIP3074", "AuthorizedTransfer")
await eip3074.counter() INFO:kakarot_scripts.utils.kakarot:⏳ Deploying AuthorizedTransfer
INFO:kakarot_scripts.utils.kakarot:ℹ️ Contract at address 0x44712b3de69e23f62641a220dc282cab01f6073a0c7db38e9b658253005d161 already exists
INFO:kakarot_scripts.utils.kakarot:✅ AuthorizedTransfer deployed at address 0x5FC8d32690cc91D4c39d9d3abcBD16989F875707
0 |
ClementWalter
previously approved these changes
Apr 18, 2024
enitrat
reviewed
Apr 18, 2024
ClementWalter
approved these changes
Apr 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 1 hour
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #1108
This change is