This repository was archived by the owner on Jan 9, 2025. It is now read-only.
feat: use Cairo1Helpers in AccountContract #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
force-pushed
the
feat/verify-signature-cairo1-helpers
branch
from
16d4b71 to
9916379
Compare
7 tasks
enitrat
force-pushed
the
feat/verify-signature-cairo1-helpers
branch
from
42c84ef to
9f8c794
Compare
Comment on lines
127
to
130
| let (latest_account_class, latest_cairo1helpers_class) = AccountContract.get_latest_classes(); | ||
| let (this_helpers_class) = Account_cairo1_helpers_class_hash.read(); | ||
| if (latest_cairo1helpers_class != this_helpers_class) { | ||
| Account_cairo1_helpers_class_hash.write(latest_cairo1helpers_class); |
There was a problem hiding this comment.
let's use this_helpers_class, latest_helpers_class and Account_helpers_class and remove everywhere the cairo1 thing (wen cairo2)
There was a problem hiding this comment.
also, is _class or _class_hash the best prefix? no strong opinion but let's just choose one
Comment on lines
+115
to
+117
| let (helpers_class) = Kakarot_cairo1_helpers_class_hash.read(); | ||
| let (point_hash) = ICairo1Helpers.library_call_keccak( | ||
| class_hash=implementation, | ||
| class_hash=helpers_class, |
There was a problem hiding this comment.
let's just decide whether it's _class or _class_hash
7 tasks
matthieuauger
pushed a commit
to matthieuauger/kakarot
that referenced
this pull request
Nov 9, 2024
* fix deployer tag * cargo toml version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.7d
Improvement metrics
Full Cairo Zero validation
Transaction resource usage: Steps: 369606 | Bitwise: 3169 | L1 Gas: 5748 | Pedersen: 165 | Range Checks: 22658
Using Cairo1_helpers's "keccak" and "verify_eth_signature" in validation
Transaction resource usage: Steps: 326384 | Bitwise: 44 | Keccak: 2 | L1 Gas: 5748 | Pedersen: 165 | Range Checks: 20971
which is a reduction of 43000 steps per tx :)
Method:
Call
counter.inc()before and after.Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #
What is the new behavior?
This change is