This repository was archived by the owner on Jan 9, 2025. It is now read-only.
feat: use keccak syscall in ecrecover #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
force-pushed
the
feat/syscall-builtin-ecrecover
branch
from
ca5c340 to
439859a
Compare
enitrat
force-pushed
the
feat/syscall-builtin-ecrecover
branch
from
31f791f to
150f778
Compare
ClementWalter
approved these changes
Apr 9, 2024
This was referenced Apr 11, 2024
Merged
matthieuauger
pushed a commit
to matthieuauger/kakarot
that referenced
this pull request
Nov 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.3d
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #966
What is the new behavior?
public_key_point_to_eth_addressto use a library call to the Cairo1 library instead of the step-based Keccak.This change is