Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

feat: estimate_gas #1074

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat: estimate_gas #1074

merged 1 commit into from
Apr 5, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Apr 4, 2024 •
edited
Loading

Time spent on this PR: 0.2d

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1067

What is the new behavior?

  • Adds an eth_estimate_gas entrypoint that returns the required gas for the transaction to run successfully. This is different from gas_used, s.t. required gas >= gas used, as the EVM can reimburse gas after its execution.

This change is Reviewable

@ClementWalter ClementWalter merged commit 3dcbada into main Apr 5, 2024
7 checks passed
@ClementWalter ClementWalter deleted the feat/estimate_gas_entrypoint branch April 5, 2024 09:40
This was referenced Apr 11, 2024
Merged
Merged
@ClementWalter ClementWalter mentioned this pull request May 30, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ClementWalter ClementWalter ClementWalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add estimate_gas entrypoint that doesn't substract gas refunds
2 participants
@enitrat @ClementWalter