Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

feat: deploy account from zero #1065

Merged
merged 11 commits into from
Apr 5, 2024
Merged

feat: deploy account from zero #1065

merged 11 commits into from
Apr 5, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Apr 3, 2024

Time spent on this PR: 0.3d

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1064 Resolves #1046

What is the new behavior?

  • Deploys accounts from zero to allow anyone to deploy an account for Kakarot.

This change is Reviewable

@enitrat enitrat force-pushed the feat/account-deploy-from-zero branch from acf0c28 to a51faaa Compare April 3, 2024 20:21
@enitrat enitrat force-pushed the feat/account-deploy-from-zero branch 2 times, most recently from c4e268c to 8551b43 Compare April 4, 2024 18:22
@enitrat
Copy link
Collaborator Author

enitrat commented Apr 4, 2024

@ClementWalter once I have your greenlight I adapt the EF-Test runner accordingly, and then we can merge everything

docs are in #1056

Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall

@ClementWalter ClementWalter mentioned this pull request Apr 5, 2024
7 tasks
@enitrat enitrat force-pushed the feat/account-deploy-from-zero branch from a89c8a3 to 2e51632 Compare April 5, 2024 14:31
Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@enitrat enitrat merged commit 268f386 into main Apr 5, 2024
7 checks passed
@enitrat enitrat deleted the feat/account-deploy-from-zero branch April 5, 2024 18:16
This was referenced Apr 11, 2024
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
* bump reth to v0.2.0-beta.7

* fix comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: deploy accounts from zero address dev: decide a deployment strategy for UninitializedAccount
2 participants